Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Users filtering in Management UI #6990

Merged
merged 2 commits into from
Jan 26, 2023
Merged

Conversation

ikavgo
Copy link
Contributor

@ikavgo ikavgo commented Jan 21, 2023

Closes #4908

Proposed Changes

Replaced filter_ui with paginated_ui as suggest in the issue description.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue Management UI: filtering users doesn't work as expected #4908)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

none

@michaelklishin michaelklishin changed the title Fix Users filtering in Management UI. Fix Users filtering in Management UI Jan 21, 2023
@ikavgo
Copy link
Contributor Author

ikavgo commented Jan 24, 2023

@michaelklishin failing test suite:

Failed suites

  • definitions.sh

Is it related to this fix? I still can't run selenium locally :-(

@ikavgo ikavgo merged commit eddb3fa into main Jan 26, 2023
@ikavgo ikavgo deleted the mgmt-users-filter-fix-4908 branch January 26, 2023 17:12
michaelklishin added a commit that referenced this pull request Jan 27, 2023
Fix Users filtering in Management UI (backport #6990) (backport #7059)
michaelklishin added a commit that referenced this pull request Jan 27, 2023
Fix Users filtering in Management UI (backport #6990) (backport #7059) (backport #7061)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Management UI: filtering users doesn't work as expected
3 participants