Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See #5957. CLI cmd to generate hashed password from cleartext password #7003

Merged
merged 1 commit into from Jan 24, 2023

Conversation

SimonUnge
Copy link
Collaborator

Proposed Changes

Add cli cmd that generates a valid hashed password according to configured rabbitmq algorithm
Addresses cli cmd part of #5957

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • [ √] If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

@lukebakken lukebakken self-assigned this Jan 23, 2023
lukebakken
lukebakken previously approved these changes Jan 23, 2023
Copy link
Collaborator

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@michaelklishin
Copy link
Member

@SimonUnge can you please rebase this PR?

@SimonUnge
Copy link
Collaborator Author

@SimonUnge can you please rebase this PR?

Done @michaelklishin

@michaelklishin
Copy link
Member

We don't have to do this in this PR but one thing the community is guaranteed to ask for is support for password entry via standard input. See rabbitmqctl change_passowrd and rabbitmqctl add_user for examples of how we do it in other places.

@michaelklishin michaelklishin merged commit 314c90a into rabbitmq:main Jan 24, 2023
michaelklishin added a commit that referenced this pull request Jan 24, 2023
See #5957. CLI cmd to generate hashed password from cleartext password (backport #7003)
michaelklishin added a commit that referenced this pull request Jan 24, 2023
See #5957. CLI cmd to generate hashed password from cleartext password (backport #7003) (backport #7010)
lukebakken added a commit that referenced this pull request Feb 25, 2023
This allows `rabbitmqctl hash_password` to run without having RabbitMQ up.

Follow-up to:
* #5957
* #7003
mergify bot pushed a commit that referenced this pull request Feb 26, 2023
This allows `rabbitmqctl hash_password` to run without having RabbitMQ up.

Follow-up to:
* #5957
* #7003

(cherry picked from commit d9d6e1b)
mergify bot pushed a commit that referenced this pull request Feb 26, 2023
This allows `rabbitmqctl hash_password` to run without having RabbitMQ up.

Follow-up to:
* #5957
* #7003

(cherry picked from commit d9d6e1b)
(cherry picked from commit 33bf1d8)
mergify bot pushed a commit that referenced this pull request Feb 26, 2023
This allows `rabbitmqctl hash_password` to run without having RabbitMQ up.

Follow-up to:
* #5957
* #7003

(cherry picked from commit d9d6e1b)
(cherry picked from commit 33bf1d8)
(cherry picked from commit 9cec4a5)

# Conflicts:
#	deps/rabbitmq_cli/lib/rabbitmq/cli/ctl/commands/add_vhost_command.ex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants