Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐲 Release 1.2.0 #31

Merged
merged 10 commits into from
May 26, 2023
Merged

🐲 Release 1.2.0 #31

merged 10 commits into from
May 26, 2023

Conversation

rabisnaqvi
Copy link
Owner

  • 🤯 Updated the getState function to return an array (tuple) similar to how React's useState hook works (Update getState to return an array, which could be extracted like react useState. #14 )
  • ✅ Updated unit tests to match the updated response from Astral.context.getState.
  • 📃 Fix broken hyperlink in the Getting Started section (Fix broken hyperlink in the Getting Started section #26 )
    • Replaced the broken hyperlink reference with the correct anchor link to the "Core Concepts" section.
    • Ensured that the anchor link matches the heading in the "Core Concepts" section.
  • 🌀 Integrate Typescript or babel (Integrate Typescript or babel #15 )
    • Converted all the source files to TypeScript namespaces.
    • Updated build process to parse the javascript files.
    • Replaced JSDOC with TypeDoc to generate documentation for the new typescript codebase.
    • Updated ESLINT configuration to be integrated with TypeScript.
    • Added some unit tests.
  • 📃Break features and definitions into different lines in readme (Break features and definitions into different lines in readme. #24 )
    • Updated readme.md to fix the line breaks and to reflect new updated features in Astral.context.getState and Astral.context.updateState.
  • 📃Updated CONTRIBUTING.md
    • Updated CONTRIBUTING.md to ensure updated contributing processes.

Rabis Naqvi and others added 10 commits May 25, 2023 00:02
Added Github Repo token to be passed into the coveralls action.
44e674b
Update CI pipeline to run on release-candidate as well.
4973341
@rabisnaqvi
Update main.yml
431ed88
@rabisnaqvi
Update main.yml for the CI to be triggered on main and release-candid…
587623c 
…ate branch
@rabisnaqvi @Siar416
14 update getstate to return an array which could be extracted like r…
62b3150 
…eact usestate (#21)

🤯 Update getState to return an array, which could be extracted like react useState.#14

* Updated the getState function to return an array similiar to how useState hook works

* Minor adjustment, instead of passing setState we are now passing a lister function instead.

* Update getState to return an array, which could be extracted like react useState.#14

* Updated unit tests to match the updated response from Astral.context.getState.

---------

Co-authored-by: Siar <83523212+Siar416@users.noreply.github.com>
Co-authored-by: Rabis Naqvi <rabis.naqvi@xynotech.com>
@rabisnaqvi @Hasrivastav
📃 #25 fix the code concepts link (#27)
0524c63 
📃 Fix broken hyperlink in the Getting Started section (#26)

This pull request addresses the issue of a broken hyperlink in the "Getting Started" section of the readme.md file. The existing hyperlink reference to the "Core Concepts" section was incorrect and did not navigate to the intended location. I have fixed the hyperlink by replacing it with the correct anchor link that matches the heading in the "Core Concepts" section.

Changes made:

Replaced the broken hyperlink reference with the correct anchor link to the "Core Concepts" section.
Ensured that the anchor link matches the heading in the "Core Concepts" section.
Please review this pull request and consider merging it into the main branch. Thank you for your attention and consideration.

Related issue: [#25 ]

Co-authored-by: HARSH SRIVASTAV <96014384+Hasrivastav@users.noreply.github.com>
@rabisnaqvi
🌀Integrate Typescript or babel#15 (#29)
7a29c78 
Converted all the source files to TypeScript namespaces.
Updated build process to parse the javascript files.
Replaced JSDOC with TypeDoc to generate documentation for the new typescript codebase.
Updated ESLINT configuration to be integrated with TypeScript.
Added some unit tests.

Co-authored-by: Rabis Naqvi <rabis.naqvi@xynotech.com>
@rabisnaqvi
📃Break features and definitions into different lines in readme. #24 (#30
6b8f0be 
)

Updated readme.md to fix the line breaks and to reflect new updated features in Astral.context.getState and Astral.context.updateState.

Co-authored-by: Rabis Naqvi <rabis.naqvi@xynotech.com>
📃Updated CONTRIBUTING.md
e0bfcb1 
Updated CONTRIBUTING.md to ensure updated contributing processes.
🐲Release 1.2.0
20743ce
@coveralls
Copy link
Collaborator

coveralls commented May 26, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5094710967

  • 63 of 64 (98.44%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.07%) to 93.103%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/layout.ts 25 26 96.15%
Totals Coverage Status
Change from base Build 5054157766: 1.07%
Covered Lines: 142
Relevant Lines: 149
💛 - Coveralls

@rabisnaqvi rabisnaqvi merged commit 9933c94 into main May 26, 2023
7 checks passed
This was referenced May 26, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Astral.js Main Development Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rabisnaqvi @coveralls