Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report of the plugin not working in 2.5.2+ #31

Closed
mouneyrac opened this issue Sep 24, 2013 · 2 comments
Closed

Report of the plugin not working in 2.5.2+ #31

mouneyrac opened this issue Sep 24, 2013 · 2 comments
Labels

Comments

@mouneyrac
Copy link
Collaborator

https://moodle.org/plugins/view.php?plugin=auth_googleoauth2

Regul RedTue, 24 Sep 2013, 10:01 PM
This plugin not work in my Moodle 2.5.2+

I research problem and find, what there is error in /auth/googleauth2/auth.php

In line 359 used authenticate_user_login function, that dont work with empty second parameter (password).

Replace
$user = authenticate_user_login($username, null);
-->
$user = get_complete_user_data('username', $username, $CFG->mnet_localhost_id);
or $DB-> get_record function
solve this problem.

@mouneyrac
Copy link
Collaborator Author

I tried on the latest 2.5 stable version, it works well for me. I also check the code I don't think it's an issue to have the password set to null as the plugin is defined with prevent_local_passwords set to true and user_login ignores the password. It should work.

If someone can reproduce, please enable debug mode and indicate the php error.

@mouneyrac
Copy link
Collaborator Author

Closing as no answer. Please feel free to reopen or open new issue if problem persist (don't forget to mention everything needed to help reproduce the issue: exact and full steps to reproduce the error, exact and full error messages, expected result, evironment PHP version, Apache version, database version...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant