Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle params key encoding error. #640

Closed
wants to merge 1 commit into from
Closed

Handle params key encoding error. #640

wants to merge 1 commit into from

Conversation

nanaya
Copy link
Contributor

@nanaya nanaya commented Jan 7, 2014

Explicitly raise error in case of encoding error.

Updated to default decode to binary. Fixes(?) #610.

@nanaya
Copy link
Contributor Author

nanaya commented May 18, 2014

Updated to encode string to binary by default.

@nanaya
Copy link
Contributor Author

nanaya commented May 18, 2014

The alternative is to pass through whatever encoding the query string is using, something like this

def unescape(s)
  URI.decode_www_form_component(s, s.encoding)
end

@raggi raggi added this to the Rack 1.6 milestone Jul 6, 2014
By changing default encoding to BINARY, allowing arbitrary regexp to pass.
@tenderlove
Copy link
Member

Fixed by #713

@tenderlove tenderlove closed this Jul 18, 2014
@nanaya nanaya deleted the utf8_params_key branch July 19, 2014 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants