Try harder when deciding whether to add a new array element #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only move to a new entry if the end key is taken; checking only the top-level key is insufficient.
|
For what it's worth, this fix does successfully address all the use cases I reported. |
| @@ -135,6 +134,18 @@ def params_hash_type?(obj) | |||
| obj.kind_of?(@params_class) | |||
| end | |||
|
|
|||
| def params_hash_has_key?(hash, key) | |||
| return false if key =~ /\[\]/ | |||
There was a problem hiding this comment.
I'm probably missing something, but it would seem since you are splitting on [], that the guard clause would ensure that [] exists in the query?
return false if key !~ /\[\]/Then again, I probably just missed the nuance here.
Yay make rack better!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only move to a new entry if the end key is taken; checking only the top-level key is insufficient.
This implementation is pretty unfortunate, but is the option that minimizes changes to
normalize_params. I'm tempted to try for a more invasive (and correspondingly less tacked-on) alternative, though.Fixes #1086, rails/rails#23997
cc @rthbound @bquorning @bmedenwald