Allow users to disable the secure cookie warning for custom coders #900
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Since we've recently updated Rack we've been getting the "No secret option provided to Rack::Session::Cookie" warning in our logs. However we are providing a custom coder to
Rack::Session::Cookie
that handles all of the encryption:https://github.com/heroku/identity/blob/master/lib/identity/main.rb#L12-L19
This pull request adds an option to
Rack::Session::Cookie
to disable this warning, but only if a coder is supplied in the cases were the user wants to manage the cookie encryption themselves:Does this approach make sense? If not I'm happy to hear alternatives.
Thanks!