Events #436
Closed
Events #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most of work is done already, i can think only about some refactoring. Let's treat it as RFC :) |
|
|
||
| @Override | ||
| public void handle(ChannelHandlerContext ctx, HttpRequest request) { | ||
| final String tenantId = request.getHeader("tenantId"); |
There was a problem hiding this comment.
NIT: Can we extract these constants in Utils instead of hard coding them here?
There was a problem hiding this comment.
Sure, you've just helped me understand where they would go :)
Just not to decrease total coverage
Closed
|
This work is being continued in PR #477 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds events (annotations). Events interface mimics
graphite-webAPI.{ "what": "", "when": 0, "tags": "", "data": "" }POSTrequest at/events/with serialized event as request body.GETrequest at/events/get_data. Returns array of events. Acceptsfrom,until,tagsquery parameters.Store events in
ElasticSearchwithtenant-idas routing parameter.