Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in metric name 'cert_subject_alternative_name' of remote.http check #48

Closed
2 of 7 tasks
itzg opened this issue Nov 30, 2017 · 5 comments
Closed
2 of 7 tasks
Assignees

Comments

@itzg
Copy link

itzg commented Nov 30, 2017

What do you want us to know about?

(Check all that apply.)

Report a documentation issue

  • Bug (misspellings, grammatical problems, broken link, format issues)
  • Missing information
  • Incorrect information
  • Feedback or suggestions
  • Other

Product

  • Product bug
  • Product feedback

Note: For product-related issues, you can also submit an issue from the Rackspace Community Forum website.

Tell us more about your issue

The metric name highlighted here is missing an "s". It should be cert_subject_alternative_names.

image

I'm not sure where this should go, but I would recommend providing an example alarm snippet for that metric that contains:

if (metric['cert_subject_alternative_names'] nregex '.*example.com.*') {
  return new AlarmStatus(CRITICAL, 'Missing expected SAN');
}

where the customer replaces "example.com" with an expected hostname on the certificate's SAN list.

@cyrichardson
Copy link
Contributor

Thank you! I will get these changes done this week and ask for your review, @itzg.

@cyrichardson cyrichardson self-assigned this Dec 5, 2017
@cyrichardson
Copy link
Contributor

cyrichardson commented Dec 6, 2017

Change in PR #50. Change made in remote.http section. Do they need to be made in remote.smtp-banner as well? There is an occurrence of cert_subject_alternative_name there.

@itzg Please review content change in PR.

@itzg
Copy link
Author

itzg commented Dec 6, 2017

Sorry, I had missed your question at first. Good catch -- it does look like the plural is the correct form in all check types.

@cyrichardson
Copy link
Contributor

@itzg Thanks! I'll fix the 2nd occurrence too and make it part of the same PR. Really appreciate your reporting and review of the PR!

@cyrichardson
Copy link
Contributor

Closed by #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants