Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug? #43

Closed
soegaard opened this issue Nov 25, 2021 · 1 comment
Closed

Possible bug? #43

soegaard opened this issue Nov 25, 2021 · 1 comment

Comments

@soegaard
Copy link
Member

While reading draw/private/dc I saw a line that may or may not be a bug.

In make-pattern-surface a new surface s is created.
Then a cairo context cr2 is created and a few settings are made using cr2.
But in line 868 the setting is made to cr and not cr2.
I am wondering whether this was on purpose?

https://github.com/racket/draw/blob/master/draw-lib/racket/draw/private/dc.rkt#L868
image

@soegaard
Copy link
Member Author

Turns out make-pattern-surface despite its name isn't a general function.
It's only used in the code that draws stipples - and it makes sense that stipples are drawn with a round line cap.
While reading from top-to-bottom it was difficult to see that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant