Add pretty-printing support to write-json and friends. #2100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New #:indent keyword which, if provided with an integer, will pretty-print output at that indentation level.
|
This has a couple small conflicts now -- @cwebber can you resolve them? |
sorawee
reviewed
Jul 7, 2020
| @examples[#:eval ev | ||
| (with-output-to-string | ||
| (λ () (write-json #hasheq((waffle . (1 2 3)))))) | ||
| (with-output-to-string | ||
| (λ () (write-json #hasheq((와플 . (1 2 3))) | ||
| #:encode 'all))) | ||
| (displayln |
There was a problem hiding this comment.
If you really want to display, I think you can use write-json directly without displayln and with-output-to-string. For consistency though, I think it probably should evaluate to a string value.
|
There probably should be tests? The test file is at https://github.com/racket/racket/blob/master/pkgs/racket-test/tests/json/json.rkt. |
LiberalArtist
added a commit
to LiberalArtist/racket
that referenced
this pull request
Jun 30, 2023
Closes racket#4300 Closes racket#2100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New #:indent keyword which, if provided with an integer, will pretty-print output at that indentation level.
Licensed under MIT (Expat) / Apache V2 / LGPLv3+, Racket maintainers' pick.