One line revert to patch: 41fd4f3a5e0c6d4ca0ef822b168bf33a5c9068a6 #2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs had an erroneous 'only, probably from development, that should be removed.
lexi-lambda
reviewed
Jun 27, 2018
| @@ -232,7 +232,7 @@ identifier, the @racket[exn:fail:contract] exception is raised. | |||
|
|
|||
| @defproc[(local-expand [stx any/c] | |||
| [context-v (or/c 'expression 'top-level 'module 'module-begin list?)] | |||
| [stop-ids (or/c (listof identifier?) (cons/c 'only (listof identifier?)) #f)] | |||
| [stop-ids (or/c (listof identifier?) empty #f)] | |||
There was a problem hiding this comment.
I’d just remove the empty special case altogether. It is subsumed by the (listof identifier?) contract, and with other changes, an empty list is less special than it used to be. I think documenting it separately is just confusing.
|
I think the change that this PR changes has gone away – right @lexi-lambda? |
|
Yes, I think you’re right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs had an erroneous 'only, probably from development, that should
be removed.