Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid incorrect use of cadr. #2848

Merged
merged 1 commit into from
Oct 6, 2019
Merged

Avoid incorrect use of cadr. #2848

merged 1 commit into from
Oct 6, 2019

Conversation

samth
Copy link
Sponsor Member

@samth samth commented Oct 6, 2019

Fixes #2847.

@gus-massa
Copy link
Contributor

I didn't find other similar error. I hope this can be merged for 7.5.

@jbclements jbclements merged commit 4fb8e4a into racket:master Oct 6, 2019
@jbclements
Copy link
Collaborator

LGTM. Interesting shadowing issue here; in some ways, it's another roundabout argument against shadowing; if the arguments had been named something other than car & cdr, it might have been less tempting to write cadr.

@rfindler
Copy link
Member

rfindler commented Oct 6, 2019 via email

MarcKaufmann pushed a commit to MarcKaufmann/racket that referenced this pull request Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashes when attempting to construct (unquote [value])
4 participants