Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The values returned by make-custom-hash-types and make-custom-set-types have a different order. Change one of them to improve consistency. #29

Open
spdegabrielle opened this issue Jul 18, 2019 · 2 comments

Comments

@spdegabrielle
Copy link
Sponsor Member

@gus-massa
The values returned by make-custom-hash-types and make-custom-set-types have a different order. Change one of them to improve consistency.

@sorawee
Copy link
Contributor

sorawee commented Jul 28, 2019

Oh, another thing that is inconsistent between hash and set is the constructors:

For sets, we have: set (which is immutable), mutable-set, weak-set.

For hash maps, we have: hash (which is immutable), make-hash, make-immutable-hash, make-weak-hash.

Cross-ref: #49

@MarcKaufmann
Copy link
Sponsor

I am not sure if this fits best here, but I have several times hit the issue with making hashes with hash vs make-hash:

  • (hash key1 value1 key2 value2 ...) vs
  • (make-has (list (cons key1 value1) (cons key2 value2)))

I don't see a reason why hash and make-hash take arguments in different orders. Maybe related to #10, but probably complementary to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants