Fix memory hole while uploading 5G chunks #620
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josvazg
force-pushed
the
fix/stream_copy
branch
2 times, most recently
from
8f71c5a
to
8c9dc3e
Compare
The call read(MAX_FILE_SIZE) will load the hole MAX_FILE_SIZE into memory, which turns to be 5GB. That puts the system to a crawl. Instead, the better way to go around this is to use streaming, copying small chunks of memory in a loop until all bytes are transferred. Apart from that: - xreadlines has been deprecated for quite a while now: https://www.quantifiedcode.com/knowledge-base/maintainability/%60.xreadlines()%60%20deprecated/7lC2NACa - Tox was not able to run pypy test env properly without the explicit dependencies on requests and nose. Includes unitests for copy_maxlen_bytes: - One test for the typical case; several writes, last one shorter - EOF test; copy ends before maxlen due to EOF reached first - Exact copies; when bufsize is a exact divisor of maxlen - One copy; when maxlen is less than bufsize
josvazg
force-pushed
the
fix/stream_copy
branch
from
4909b33
to
6f797f5
Compare
|
We're currently phasing out Pyrax in favor of openstacksdk/rackspacesdk and are not currently accepting changes like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call read(MAX_FILE_SIZE) will load the hole MAX_FILE_SIZE into
memory, which turns to be 5GB. That puts the system to a crawl.
Instead, the better way to go around this is to use streaming, copying
small chunks of memory in a loop until all bytes are transferred.
Python provides shutil.copyfileobj that saves you even writting the loop
explicitly.
Apart from that:
https://www.quantifiedcode.com/knowledge-base/maintainability/%60.xreadlines()%60%20deprecated/7lC2NACa
dependencies on requests and nose.