Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vi-mode indicator #14611

Closed
XVilka opened this issue Jul 22, 2019 · 8 comments
Closed

Vi-mode indicator #14611

XVilka opened this issue Jul 22, 2019 · 8 comments

Comments

@XVilka
Copy link
Contributor

XVilka commented Jul 22, 2019

To show the state of the dietline - insert mode or a command mode. Should be shown in the vi-mode only. What do you think? Will be it useful enough?

@xx55x
Copy link

xx55x commented Jul 23, 2019

This would definitely be useful in my opinion. I may be biased I always have the mode visible in readline. I’d say it would be a great feature though.

@deepakchethan
Copy link
Contributor

It would definitely be useful, but where would we make the indicator appear ?

@XVilka
Copy link
Contributor Author

XVilka commented Aug 8, 2019

The rightmost position of the prompt maybe? @radare what do you think?

@radare
Copy link
Collaborator

radare commented Aug 8, 2019 via email

@deepakchethan
Copy link
Contributor

ping @radare @XVilka decided anything?

@XVilka
Copy link
Contributor Author

XVilka commented Sep 5, 2019

I suggest the following:

  • Add the option scr.prompt.mode=true
  • Show the different color of the prompt depending if it is a normal or insert mode. Maybe make the normal mode of the complement color of the insert prompt mode one?

@deepakchethan
Copy link
Contributor

Sounds good, will make a pr

deepakchethan added a commit to deepakchethan/radare2 that referenced this issue Sep 9, 2019
@radare radare closed this as completed in f1646f7 Sep 9, 2019
@XVilka
Copy link
Contributor Author

XVilka commented Sep 11, 2019

@deepakchethan can you please send a PR to radare2book with a few lines about this option and how to detect when it's normal mode, and when it's insert one? Maybe with a screenshot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants