-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some docs + unit tests #115
Conversation
looks red |
As I told you yesterday, with the last commits you just hide the bug of |
dont push a breaking test without the fix
|
let's bury our heads in the sand then :P i will write more tests... then we can see how to fix things |
http://i1.kym-cdn.com/entries/icons/original/000/018/012/Screen_Shot_2015-05-12_at_3.31.31_PM.png http://i1.kym-cdn.com/entries/icons/original/000/018/012/Screen_Shot_2015-05-12_at_3.31.31_PM.png
|
can you fix that issue in the same pr? |
i know this change implies asuming that length doesnt contains the tailing \0 |
tired of waiting. will fix it myself |
see 2d45c1c it was just 1 loc |
No description provided.