Add some docs + unit tests

[ret2libc]

No description provided.

[radare]

looks red

[ret2libc]

As I told you yesterday, with the last commits you just hide the bug of key_len. This new tests show it again (in particular at line https://github.com/radare/sdb/pull/115/files#diff-8ed9a6a44ab7365326573ab0e2597e65R118 )

[radare]

dont push a breaking test without the fix

On 26 Oct 2016, at 10:28, Riccardo Schirone notifications@github.com wrote:

As I told you yesterday, with the last commits you just hide the bug of key_len. This new tests show it again (in particular at line https://github.com/radare/sdb/pull/115/files#diff-8ed9a6a44ab7365326573ab0e2597e65R118 https://github.com/radare/sdb/pull/115/files#diff-8ed9a6a44ab7365326573ab0e2597e65R118 )

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub #115 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-ltJygBkjxPQI_XPbauONlA1Zi9Foks5q3w8RgaJpZM4Kgfut.

[ret2libc]

let's bury our heads in the sand then :P i will write more tests... then we can see how to fix things

[radare]

http://i1.kym-cdn.com/entries/icons/original/000/018/012/Screen_Shot_2015-05-12_at_3.31.31_PM.png http://i1.kym-cdn.com/entries/icons/original/000/018/012/Screen_Shot_2015-05-12_at_3.31.31_PM.png

On 26 Oct 2016, at 23:19, Riccardo Schirone notifications@github.com wrote:

let's bury our heads in the sand then :P i will write more tests... then we can see how to fix things

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub #115 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-lt1MQHO0TSfBmdRE3EdvutWGFt2_ks5q38PUgaJpZM4Kgfut.

[radare]

can you fix that issue in the same pr?

[radare]

i know this change implies asuming that length doesnt contains the tailing \0

[radare]

tired of waiting. will fix it myself

[radare]

see 2d45c1c it was just 1 loc