Implement showing map names with "dm" on Windows

[xdp0]

It would be nice if dm command on Windows showed module names and mapped file names.

I guess there was such a feature before. From radare2/libr/debug/p/native/maps/windows_maps.c:

/* get process modules list */
RList *mod_list = NULL; // r_w32_dbg_modules (dbg);

And one more line from the same file:

DWORD len = 0; // r_w32_GetMappedFileName (h_proc, mbi->BaseAddress, f_name, MAX_PATH);

But it's commented now. What was the reason for commenting it?

[trufae]

I think the reason was because it was causing segfaults on some windows if the api was not available or the abi changed between mingw and msvc. But thats just from memory didnt git blamed to find the actual commit. Feel free to try uncommenting and testing again because the toolchains has changes over time and maybe this issue is gone now

[xdp0]

OK I will. The actual is commit is 3e03207 btw. Don't you remember the Windows version/arch where it segfaulted?

[trufae]

I use to test wxp 32bit and w11 x64. W95 was working at some point but im not sure whats the state of it now

[trufae]

@xdp0 anyupdate here? can you submit a pr fixing that and test if it works with latest code from git? thanks!

[xdp0]

Sorry, I am still far away from any computer, will be available to do fixes only after 10 days ><05:02, 16 апреля 2024 г., pancake ***@***.***>: @xdp0 anyupdate here? can you submit a pr fixing that and test if it works with latest code from git? thanks! —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***> -- Отправлено из мобильного приложения Яндекс Почты

[trufae]

Just tested your proposal and it seems to work at least on w10.