Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicated entry symbols in macho ##bin #17277

Merged
merged 2 commits into from
Jul 15, 2020
Merged

Fix duplicated entry symbols in macho ##bin #17277

merged 2 commits into from
Jul 15, 2020

Conversation

trufae
Copy link
Collaborator

@trufae trufae commented Jul 14, 2020 •
edited
Loading

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the documentation and the radare2 book with the relevant information (if needed)

Detailed description

Solves #17233

Test plan

theres a test

Closing issues

#17233

@trufae trufae requested review from ret2libc and mrmacete July 14, 2020 12:16
@trufae trufae mentioned this pull request Jul 14, 2020
Merged
4 tasks
ret2libc
ret2libc approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@ret2libc ret2libc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I leave the last word to @mrmacete !

@trufae trufae changed the title Cleaner attempt to fix the ghost macho symbols ##bin Fix duplicated entry symbols in macho ##bin Jul 14, 2020
@XVilka XVilka merged commit 2949708 into radareorg:master Jul 15, 2020
XVilka pushed a commit that referenced this pull request Jul 15, 2020
@trufae @radare
Fix duplicated entry symbols in macho ##bin (#17277)
0321bf7 
* Cleaner attempt to fix the ghost macho symbols ##bin

Co-authored-by: pancake <pancake@nopcode.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ret2libc ret2libc ret2libc approved these changes

@mrmacete mrmacete mrmacete approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@trufae @ret2libc @mrmacete @XVilka @radare