Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Gradle 8 #322

Merged
merged 18 commits into from
Oct 10, 2023
Merged

Adopt Gradle 8 #322

merged 18 commits into from
Oct 10, 2023

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Oct 8, 2023

Closes #321.

renovate bot and others added 16 commits October 8, 2023 08:49
* Update dependency org.spekframework.spek2:spek-runner-junit5 to v2.0.19

* Update dependency org.spekframework.spek2:spek-dsl-jvm to v2.0.19

* Group Spek2 updates

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Goooler <wangzongler@gmail.com>
* Update dependency gradle to v8

* Use bin

* Migrate pluginBundle

* Remove org.gradle.daemon flag

* Remove forUseAtConfigurationTime

* Use current Gradle version in tests

* Update plugin org.jetbrains.kotlin.jvm to v1.9.10

* Fix WordSpecTest

* Generate wrapper

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Goooler <wangzongler@gmail.com>
* Update circleci/openjdk Docker tag to v11

* Use toolchain

* cimg/openjdk:17.0

* Apply org.gradle.toolchains.foojay-resolver-convention

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Goooler <wangzongler@gmail.com>
@Goooler
Copy link
Contributor Author

Goooler commented Oct 8, 2023

We can rebase these commits and replace @dependabot with @renovate-bot.

@radarsh
Copy link
Owner

radarsh commented Oct 8, 2023

@Goooler thanks for this pull request. Can you justify why are you switching to renovate bot? I much prefer to use dependabot as it is built into GitHub now.

@Goooler
Copy link
Contributor Author

Goooler commented Oct 8, 2023

Can you justify why are you switching to renovate bot? I much prefer to use dependabot as it is built into GitHub now.

@renovate-bot can send the Gradle updates, and supports more kinds of dep updates.

build.gradle Show resolved Hide resolved
@radarsh
Copy link
Owner

radarsh commented Oct 8, 2023

Thanks. Lastly, is this PR going to be compatible with Gradle 7?

@Goooler
Copy link
Contributor Author

Goooler commented Oct 8, 2023

is this PR going to be compatible with Gradle 7?

It should work, maybe we should add more Gradle versions into test matrix.

@Goooler Goooler marked this pull request as draft October 8, 2023 16:25
@Goooler
Copy link
Contributor Author

Goooler commented Oct 8, 2023

Did a quick test at Goooler#27, seems need to fix some tests.

Edited: Not sure why these tests failed, but should not be relevant to the removal of Provider.forUseAtConfigurationTime.

@Goooler Goooler marked this pull request as ready for review October 8, 2023 16:48
@radarsh
Copy link
Owner

radarsh commented Oct 8, 2023

No problem, looks like some classes introduced in 7.6 are being used in your branch indirectly. I'll do some more checks later and merge this. Thanks once again.

Goooler and others added 2 commits October 8, 2023 12:52
* Use compileOnly

* Remove extra localGroovy()

* Defer tasks

* Use pluginManagement & dependencyResolutionManagement

* Migrate deprecated buildDir

* Always publish scans on CI

* Remove mustRunAfter

* Add jvmargs

* Add .gitattributes
@radarsh radarsh merged commit 1494c77 into radarsh:develop Oct 10, 2023
2 checks passed
@radarsh
Copy link
Owner

radarsh commented Oct 10, 2023

Thanks once again for a great PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Provider.forUseAtConfigurationTime method has been deprecated.
2 participants