Removed nested transaction which always commits page change on preview, Fixes GH-319 #320

Merged
merged 3 commits into from Feb 17, 2012

Conversation

Projects
None yet
2 participants
@blj
Collaborator

blj commented Feb 10, 2012

For some reason the nested transaction in Admin::PagesController#render_preview commits the transaction even though the PreviewStop error is raised. Removing the inner transaction fixes this.

@saturnflyer

This comment has been minimized.

Show comment Hide comment
@saturnflyer

saturnflyer Feb 17, 2012

Member

Why do you need to skip verify_authenticity_token?

Member

saturnflyer commented Feb 17, 2012

Why do you need to skip verify_authenticity_token?

@blj

This comment has been minimized.

Show comment Hide comment
@blj

blj Feb 17, 2012

Collaborator

@saturnflyer I thought it is not serving any purpose, it is certainly not making any change to the database. Can ignore it.

Collaborator

blj commented Feb 17, 2012

@saturnflyer I thought it is not serving any purpose, it is certainly not making any change to the database. Can ignore it.

@saturnflyer

This comment has been minimized.

Show comment Hide comment
@saturnflyer

saturnflyer Feb 17, 2012

Member

will you alter this pull request to remove that addition?

Member

saturnflyer commented Feb 17, 2012

will you alter this pull request to remove that addition?

saturnflyer added a commit that referenced this pull request Feb 17, 2012

Merge pull request #320 from blj/319-preview
Removed nested transaction which always commits page change on preview, Fixes GH-319

@saturnflyer saturnflyer merged commit dd27da8 into radiant:master Feb 17, 2012

@saturnflyer

This comment has been minimized.

Show comment Hide comment
@saturnflyer

saturnflyer Feb 17, 2012

Member

Thanks for your help @blj!

Member

saturnflyer commented Feb 17, 2012

Thanks for your help @blj!

@blj

This comment has been minimized.

Show comment Hide comment
@blj

blj Feb 17, 2012

Collaborator

@saturnflyer I just did a revert on the commit, if you do not like it, let me know I can send fresh pull request instead. Thanks.

Collaborator

blj commented Feb 17, 2012

@saturnflyer I just did a revert on the commit, if you do not like it, let me know I can send fresh pull request instead. Thanks.

@blj

This comment has been minimized.

Show comment Hide comment
@blj

blj Feb 17, 2012

Collaborator

@saturnflyer Ah I see it is done already. Thanks.

Collaborator

blj commented Feb 17, 2012

@saturnflyer Ah I see it is done already. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment