Removed nested transaction which always commits page change on preview, Fixes GH-319 #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why do you need to skip |
|
@saturnflyer I thought it is not serving any purpose, it is certainly not making any change to the database. Can ignore it. |
|
will you alter this pull request to remove that addition? |
This reverts commit b345b5c.
saturnflyer
added a commit
that referenced
this pull request
Feb 17, 2012
Removed nested transaction which always commits page change on preview, Fixes GH-319
|
Thanks for your help @blj! |
|
@saturnflyer I just did a revert on the commit, if you do not like it, let me know I can send fresh pull request instead. Thanks. |
|
@saturnflyer Ah I see it is done already. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the nested transaction in Admin::PagesController#render_preview commits the transaction even though the PreviewStop error is raised. Removing the inner transaction fixes this.