Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New common band name mwir38 #1054

Closed
wants to merge 4 commits into from
Closed

Conversation

emmanuelmathot
Copy link
Collaborator

Proposed Changes:

  1. new Common band mwir38. used for instance for gaofen-4 mission

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
  • This PR affects the STAC API spec, and I have opened issue/PR #XXX to track the change.

@emmanuelmathot emmanuelmathot changed the title Emmanuelmathot mwir38 New command band mwir38 Mar 19, 2021
@emmanuelmathot emmanuelmathot changed the title New command band mwir38 New common band name mwir38 Mar 19, 2021
extensions/eo/README.md Outdated Show resolved Hide resolved
Co-authored-by: Phil Varner <philvarner@gmail.com>
@matthewhanson
Copy link
Collaborator

I thought I had written a response to this, must have never hit Comment.

The criteria for adding new common names is that the approximate location and size appears in multiple instruments. This is clearly the case for all the standard colors, Near IR and the 2 main SWIR atmospheric windows. Narrow bands tend to be too specific and unique.

MWIR is from 3-5um, and gaofen-4 MWIR is 3.5 - 4.1 um.

I've got a couple questions:

  • Are there other sensors that have an equivalent MWIR band?
  • What are some other bandpasses in use for MWIR sensors?

@emmanuelmathot
Copy link
Collaborator Author

emmanuelmathot commented Mar 24, 2021

To my knowledge, in spaceborne remote sensing, there is MODIS instrument on aqua and terra sat: https://webapps.itc.utwente.nl/sensor/getsen.aspx?name=MODIS with 6 mwir bands:

Band 20  (MWIR) | 3.66 to 3.84 |  
Band 21  (MWIR) | 3.929 to 3.989 |
Band 22  (MWIR) | 3.929 to 3.989 |
Band 23  (MWIR) | 4.02 to 4.08 |  
Band 24  (MWIR) | 4.433 to 4.498 |
Band 25  (MWIR) | 4.482 to 4.549

Then apparently, very used in airborne instruments

image

@matthewhanson
Copy link
Collaborator

It's not a question if MWIR is commonly used, but rather how common is a bandpass that is centered on 3.8um and do they tend to have a similar bandwidth. None of the MODIS bands are similar to the gaofen band.

What we want to avoid is giving these sorts of mission-specific bands a common name using the center wavelength if they aren't actually common.

@emmanuelmathot
Copy link
Collaborator Author

I understand your point. As long as this field remains open to any value, this is fine with me.
Be aware (but you probably are ;-) that this nomenclature is very useful and adopted very quickly (that's our case). I don't know where to set the cursor on the completeness of the existing sensor wavelengths but, for now, I agree with your criteria for adding new common names.
You can close this PR for now if you prefer.

@philvarner
Copy link
Collaborator

@emmanuelmathot It won't be open to any name going forward, pending resolution of this issue #1062

The reason is that these should be well-defined and have a very high bar (either used by one of the big 3 of Landsat, MODIS, or Sentinel-2) or be used by 3 or more other satellites.

I understand your use case exactly because I've had the same need. You're always able to set another proprietary field in the band description to whatever you want.

@emmanuelmathot
Copy link
Collaborator Author

ho that's bad news :-(. Indeed, we will have to use another field but that is the kind of ugly workaround I'd like to avoid because they become permanent and creates incompatibilities in the future.

@cholmes
Copy link
Contributor

cholmes commented Mar 25, 2021

Feel free to give feedback on #1062 - it made sense on our call, but I could see an argument of allowing more, and just giving a warning if it's not one of the defined ones. Certainly I want the spec to support your use case.

@matthewhanson
Copy link
Collaborator

@emmanuelmathot Can you not just use the "name" field the way you'd like?

@emmanuelmathot
Copy link
Collaborator Author

yes no worry. We will do that.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants