-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit top-level README #44
Conversation
rouson
commented
Sep 26, 2018
•
edited
Loading
edited
- Rename README as README.md to exploit GitHub-flavored Markdown.
- Format with Markdown, including inserting hyperlinks.
- Add zgoubi build instructions and docker image launch instructions.
1. Format with GitHub-flavored Markdown 2. Add zgoubi build instructions
@rouson: What is this issue you're having with the docker build? Can you run |
@rouson I reviewed the README, and I made some minor formatting, white space and spelling/typo corrections. The instructions look correct to me. Please elaborate on the behavior you're experiencing when you say
|
This looks like it's ready to merge. @rouson are we waiting on review from @robnagler and/or @dtabell? |
@zbeekman Thanks for the corrections. One needs to be reverted, however: "exemples" is the name of the referenced directory and the correct spelling in French. I'll push that change. @dtabell and I have been corresponding about this pull request on slack and will go over it the next time he and I talk so let's leave it open a bit longer. |
Sure, sounds good to me.
…On Wed, Oct 3, 2018 at 11:42 AM Damian Rouson ***@***.***> wrote:
@zbeekman <https://github.com/zbeekman> Thanks for the corrections. One
needs to be reverted, however: "exemples" is the name of the referenced
directory and the correct spelling in French. I'll push that change.
@dtabell <https://github.com/dtabell> and I have been corresponding about
this pull request on slack and will go over it the next time he and I talk
so let's leave it open a bit longer.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#44 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAREPDYH6CAp8Xguu4VKxU8mydvksqLTks5uhNrUgaJpZM4W7fbR>
.
|
The build instructions and the`docker` command given in this file now work for me so this is ready to merge.