Fix #221 flattened_basedirs on Windows by ; instead of : #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splitting paths on Windows by : is not a good idea. Since it looks like this C:\\something. That is why we disable this feature on Windows. Signed-off-by: fliiiix <hi@l33t.name>
|
@7ep let me know if this works for you as well. |
Codecov Report
@@ Coverage Diff @@
## master #307 +/- ##
==========================================
+ Coverage 89.46% 89.46% +<.01%
==========================================
Files 89 89
Lines 2686 2687 +1
==========================================
+ Hits 2403 2404 +1
Misses 283 283
Continue to review full report at Codecov.
|
timofurrer
reviewed
Feb 9, 2019
Co-Authored-By: fliiiix <hi@l33t.name>
fliiiix
force-pushed
the
bugfix/windows_basepaths
branch
from
339c9c3
to
b40c523
Compare
It sounds like the right thing to do. So why not. |
fliiiix
changed the title
timofurrer
approved these changes
Feb 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting paths on Windows by : is not
a good idea. Since it looks like this
C:\something. That is why we disable
this feature on Windows.
Signed-off-by: fliiiix hi@l33t.name