Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Unable to close Combobox with Esc key #386

Closed
2 tasks
MellKam opened this issue Mar 6, 2024 · 3 comments · Fixed by #401
Closed
2 tasks

[Bug]: Unable to close Combobox with Esc key #386

MellKam opened this issue Mar 6, 2024 · 3 comments · Fixed by #401
Labels
bug Something isn't working

Comments

@MellKam
Copy link

MellKam commented Mar 6, 2024

Reproduction

https://www.shadcn-vue.com/docs/components/combobox.html

Describe the bug

You can check that it works with shadcn-ui https://ui.shadcn.com/docs/components/combobox

System Info

-

Contributes

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests
@MellKam MellKam added the bug Something isn't working label Mar 6, 2024
@sadeghbarati
Copy link
Collaborator

sadeghbarati commented Mar 7, 2024

It is because vue-sonner bug

after this PR gets released it should be fixed

xiaoluoboding/vue-sonner#57

It was not about the vue-sonner bug, will check for the fix

@sadeghbarati
Copy link
Collaborator

sadeghbarati commented Mar 7, 2024

PopoverContent and ComboboxContent both have dismissable layers which I don't know its good or not

I like how react-aria handled this for example if set props for PopoverContent it is also applied to to same logically component in the child

@zernonia

Should I have to omit the same PopoverEmits from CommandList in shadcn-vue?

@zernonia
Copy link
Member

zernonia commented Mar 7, 2024

Yup I realized this issue. For now we can set :dismissable="false" for ComboboxContent. In future we can use ListBox component instead of combobox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants