Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala Wrapper Model parameter #2

Closed
Sciss opened this issue Oct 24, 2013 · 1 comment
Closed

Scala Wrapper Model parameter #2

Sciss opened this issue Oct 24, 2013 · 1 comment

Comments

@Sciss
Copy link

Sciss commented Oct 24, 2013

I had modified the Scala wrappers from the last SF version which is at e4c5a6c - with a similar idea to what you did in f287128 , namely to allow for different models within one application run.

My approach is slightly different, instead of having a global mutable model field, I am using an implicit model parameter:

https://github.com/iem-projects/PointLib/blob/composer_ot/src/main/scala/de/sciss/jacop/jacop.scala

I think this is more elegant, but of course it's a matter of taste. Let me know if you are interested in that version, then I could fork jacop, make that change and start a pull request.

@radsz
Copy link
Owner

radsz commented Sep 21, 2016

Thank you for your input.

I talked with Krzysztof Kuchcinski (core-developer too) who was working on Scala part in JaCoP and he said he prefers his solution. It is his decision so I close this issue. Thank you for your feedback.

@radsz radsz closed this as completed Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants