Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CICD won't build macOS due to SDK download no longer being available #17

Closed
Raelr opened this issue Jan 31, 2022 · 1 comment · Fixed by #22
Closed

CICD won't build macOS due to SDK download no longer being available #17

Raelr opened this issue Jan 31, 2022 · 1 comment · Fixed by #22
Assignees
Labels
buld system Indicates issues or features related to the project buid system

Comments

@Raelr
Copy link
Owner

Raelr commented Jan 31, 2022

Currently, the entire project depends on the Vulkan SDK to be available to build. This creates a dependency that can't easily be replicated in a CICD environment.

At the moment, the CICD system will manually download the SDK to the VM and run the tests from there. This works for Windows and Linux, however MacOS breaks due to a change in the format the SDK is provided in. As such, a new solutions needs to be found to make this work correctly.

This issue is for changing the build system to pull in the Vulkan dependencies and manually build them. This has the following advantages:
a) Allows the renderer to be build and tested in CICD.
b) Allows Vulkan to be shipped without the end user requiring the Vulkan SDK.

@Raelr Raelr added the buld system Indicates issues or features related to the project buid system label Jan 31, 2022
@Raelr Raelr self-assigned this Jan 31, 2022
@Raelr Raelr linked a pull request Jan 31, 2022 that will close this issue
@Raelr
Copy link
Owner Author

Raelr commented Feb 15, 2022

Note: looks like manually building the SDK will require either the VK_LAYER_PATH and VK_ICD_FILENAMES variables to be set. This can be circumnavigated by installing the validation layers to the user's usr/local/share folder.

@Raelr Raelr linked a pull request Apr 28, 2022 that will close this issue
@Raelr Raelr closed this as completed in #22 May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buld system Indicates issues or features related to the project buid system
Projects
None yet
1 participant