-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap 3 support #28
Conversation
To Simple Form generate this we will need a lot of changes on Simple Form code. * Labels can't generate checkbox class by default * Input can't use the form-control class configured globally * Inline label has to be the default
Check boxes support is the first problem. I listed they at 7d76738 |
+1 👍 SimpleForm BS3 support is the last blocker for myself (and I suspect many others) to upgrade BS2->BS3 |
👍 |
@rafaelfranca Thank you. Any thought when this may be available? |
Unfortunately, no |
I have created a pull request to merge with this one if you find it appropriate that solves the problems I have found so far. Please, let me know if you like/agree with my approach and if it can be improved. |
Meanwhile, any workaround for that? |
See this thread: heartcombo/simple_form#864 |
nice, thank you very much! |
Hi @rafaelfranca , What's the state of Simpleform's bootstrap 3 integration? I recall there where some changes in the core simple_form that were necessary for supporting TW3 forms. Are those changes done? Is SF ready for supporting TW3? I am particularly interested in full support for horizontal forms since that is what my website uses. I will be available this weekend so I would like to spend some time improving SF support for TW3. Let me know what tasks need to be completed and where can I be of use. Thanks. |
Hi. Simple Form still don't support Bootstrap 3. Nothing was did in the direction to make support to Bootstrap 3. I don't have time neither interest (I'm not a Bootstrap user) to work on it. I'm hoping someone at Plataformatec will work on it, but I gladly can help someone else interested on work on it, but I don't think it will be an easy task, neither a quick one. There are some requirements:
Let me know if you want to help. |
@rafaelfranca I appreciate the work your team does, however lack of BS3 support in SimpleForm is becoming a major headache. Is there a list of outstanding gaps needed for BS3 support so we can finish it--clearly there is demand in the community? |
@johnnyshields no, like I said I don't use Bootstrap so I even don't know what need to be supported. This is why I created this branch. Feel free to investigate. |
I understand. Makes total sense that you don't want to condition the design of SF just because of BS. There maybe changes though that must be done in SF in order to support Bootstrap 3, in such case – and if those changes don't make sense to be in core – I think I could just release those changes in a separate gem. Judging from the attention this issue gets, I don't think it will be a problem for us (me and interested parties) to maintain it. Sounds good? |
Thank you very much, this is some impressive work! :) |
Nice work! Thank you very much! |
Looks really beautiful, well done! |
Oh god .. Nice job :) |
Thanks @rafaelfranca, looks great 👍 |
👍 |
Sweeeeeet 🍰 |
👍 |
@lucasmazza I removed the code pretty but maybe I'll add it back again. I change the application to have only one page, but I'm planning to work in a full documentation inside this application too. Since I'm not sure when it will be done I removed the dependencies and I'll merge this branch as it is. Thank you for the review. |
Thank you for the support guys. ❤️ |
Awesome!! 👏 |
👍 Great work! |
Parabéns, trabalho show de bola!! |
Awesome!!! 👏 🎆 |
Thanks a lot! 👍 |
But how exactly do I use this? SimpleForm is still v3.0.1. |
@jmuheim A new release of the gem will be available soon, until then, an option would be point the gem to master. |
Thank you, @andrielfn! |
We just released Simple Form 3.1.0.rc1 with Bootstrap 3 support. Please give a try. http://blog.plataformatec.com.br/2014/04/bootstrap-3-support-for-simple-form/ |
👍 |
Things are generally working, except forms. The viability of this branch probably depends on this PR getting finished: heartcombo/simple_form-bootstrap#28
Closes #24 #26
Related
twbs/bootstrap#9067