Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove crispy_forms dependency #1124

Closed
rafalp opened this issue Nov 11, 2018 · 0 comments · Fixed by #1129
Closed

Remove crispy_forms dependency #1124

rafalp opened this issue Nov 11, 2018 · 0 comments · Fixed by #1129
Assignees
@rafalp
Labels
area: backend This issue involves Python, Django or dependency (eg. database) enhancement Improvement to existing feature or dev experience
Milestone
0.20.0

Comments

@rafalp
Copy link
Owner

rafalp commented Nov 11, 2018 •
edited
Loading

Looks like crispy_forms has (or used to have) problems supporting Django 2.1

We could replace this dependency with custom template tags - our most complex forms live in React.js anyway, and our admin UI that's main user of crispy_forms uses those in limited number of cases.
@rafalp rafalp added this to the 0.20.0 milestone Nov 11, 2018
@rafalp rafalp added area: backend This issue involves Python, Django or dependency (eg. database) enhancement Improvement to existing feature or dev experience labels Nov 11, 2018
@rafalp rafalp self-assigned this Nov 11, 2018
@rafalp rafalp mentioned this issue Nov 14, 2018
Merged
6 tasks
@rafalp rafalp mentioned this issue Nov 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafalp rafalp

Labels
area: backend This issue involves Python, Django or dependency (eg. database) enhancement Improvement to existing feature or dev experience
Projects
None yet
Milestone
0.20.0
Development

Successfully merging a pull request may close this issue.

Add misago_admin_form template tags rafalp/Misago
1 participant
@rafalp