Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace thread posts goto views with redirect views that use new generics and permissions system #1799

Closed
rafalp opened this issue Aug 24, 2024 · 0 comments · Fixed by #1802
Assignees
Labels
area: backend This issue involves Python, Django or dependency (eg. database) feature: thread page Thread and private thread pages feature: threads list Lists of threads

Comments

@rafalp
Copy link
Owner

rafalp commented Aug 24, 2024

All goto views tests are currently failing, but its okay because those are simple to rewrite for new permissions and generics system.

Requires new read tracker to be completed first (#1618).

Also should include new ThreadRepliesPaginator because we are dropping "repeat last post from previous page on the start of next page" thing. But we will need to know whats the first post on next page to pull thread events to display below the last post. The "which page the post is on" logic should actually live in a method on this new paginator class.

We should also have a generic redirect to post by its ID view that will be able to redirect to either private thread or regular thread. That will simplify the "go to the quoted post" logic.

@rafalp rafalp added area: backend This issue involves Python, Django or dependency (eg. database) feature: threads list Lists of threads feature: thread page Thread and private thread pages labels Aug 24, 2024
@rafalp rafalp added this to the Next feature release milestone Aug 24, 2024
@rafalp rafalp self-assigned this Aug 24, 2024
@rafalp rafalp closed this as completed Sep 3, 2024
@rafalp rafalp reopened this Sep 3, 2024
@rafalp rafalp mentioned this issue Sep 3, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: backend This issue involves Python, Django or dependency (eg. database) feature: thread page Thread and private thread pages feature: threads list Lists of threads
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant