Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bank transfer allows sender and receiver be the same account #27

Open
lauripalonen opened this issue Apr 23, 2021 · 0 comments
Open

Bank transfer allows sender and receiver be the same account #27

lauripalonen opened this issue Apr 23, 2021 · 0 comments

Comments

@lauripalonen
Copy link

In Bank transfer exercise (Securing software, module 2.2.), it is possible for the sender and receiver be the same account. This enables incrementation of balance of a single account, while logically it should stay the same (take amount X from account A, give amount X to account A).

Suggestion: Add a test for checking that transaction is not made if sender == receiver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant