Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag --network-type and its options' names are confusing #2752

Closed
konradkonrad opened this issue Oct 10, 2018 · 6 comments
Closed

Flag --network-type and its options' names are confusing #2752

konradkonrad opened this issue Oct 10, 2018 · 6 comments

Comments

@konradkonrad
Copy link
Contributor

Problem Definition

--network-type currently supports two options: main and test. They are easily confused with the --network-id parameter for the Ethereum chain, i.e. mainnet.
From what I gathered, not even the name "network type" is very descriptive.

I'm putting this issue up for discussion, but here are some proposals:

  • --protocol-configuration release|dev
  • --environment release|dev

As for the option names, I could also think of

  • live|sandbox

Other suggestions welcome!

@andrevmatos
Copy link
Contributor

How about prod|dev or production|development, as in angular/js builds?

@LefterisJP
Copy link
Contributor

Plus one for production|development

@konradkonrad
Copy link
Contributor Author

Can we also get some eyes on the option name?

@LefterisJP
Copy link
Contributor

Can we also get some eyes on the option name?

operational-configuration?

So --operational-configuration production or --operational-configuration development?

@andrevmatos
Copy link
Contributor

In JS realm, it's called --environment, or --env, not sure if it applies here

@junaidev
Copy link
Contributor

I am using https://github.com/raiden-network/raiden/releases/tag/v0.14.0 build and connected with a private eth net. When registering new token I am getting {"errors": "Registering a new token is currently disabled in the Ethereum mainnet"} while using ./raiden-v0.14.0-linux --config-file config.toml --environment-type development cli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants