Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace api version 1 with v1 #3157

Closed
2 tasks
LefterisJP opened this issue Dec 13, 2018 · 0 comments
Closed
2 tasks

Replace api version 1 with v1 #3157

LefterisJP opened this issue Dec 13, 2018 · 0 comments
Assignees
@LefterisJP

Comments

@LefterisJP
Copy link
Contributor

Problem Definition

It was mentioned in the Services syncup meeting on 13.12.2018 that we should have v1 instead of 1 in the API to be consistent in the way other APIs are defined.

So GET /api/1/address -> GET /api/v1/address.

This change should happen right now before Red Eyes since it will be a breaking compatibility change.

@ulope suggested the above and all in the meeting were in agreement.

Task

  • Make sure that the API version is prefixed with a v
  • Change all the mentions in the doc to reflect this in the api guide
@LefterisJP LefterisJP self-assigned this Dec 13, 2018
LefterisJP added a commit to LefterisJP/raiden that referenced this issue Dec 13, 2018
@LefterisJP
Add a v prefix to the api version
7ce588e 
Fix raiden-network#3157
@LefterisJP LefterisJP mentioned this issue Dec 13, 2018
Merged
LefterisJP added a commit to LefterisJP/raiden that referenced this issue Dec 13, 2018
@LefterisJP
Add a v prefix to the api version
f5df450 
Fix raiden-network#3157
LefterisJP added a commit to LefterisJP/raiden that referenced this issue Dec 14, 2018
@LefterisJP
Add a v prefix to the api version
21a22f8 
Fix raiden-network#3157
hackaugusto pushed a commit to hackaugusto/raiden that referenced this issue Jan 18, 2019
@LefterisJP @hackaugusto
Add a v prefix to the api version
8fb47bb 
Fix raiden-network#3157
hackaugusto pushed a commit to hackaugusto/raiden that referenced this issue Jan 18, 2019
@LefterisJP @hackaugusto
Add a v prefix to the api version
f1ef5ec 
Fix raiden-network#3157
hackaugusto pushed a commit to hackaugusto/raiden that referenced this issue Jan 18, 2019
@LefterisJP @hackaugusto
Add a v prefix to the api version
6cc203a 
Fix raiden-network#3157
hackaugusto pushed a commit to hackaugusto/raiden that referenced this issue Jan 18, 2019
@LefterisJP @hackaugusto
Add a v prefix to the api version
37fdd19 
Fix raiden-network#3157
hackaugusto pushed a commit to hackaugusto/raiden that referenced this issue Jan 18, 2019
@LefterisJP @hackaugusto
Add a v prefix to the api version
b75c1fb 
Fix raiden-network#3157
hackaugusto pushed a commit to hackaugusto/raiden that referenced this issue Jan 18, 2019
@LefterisJP @hackaugusto
Add a v prefix to the api version
005d62c 
Fix raiden-network#3157
hackaugusto pushed a commit to hackaugusto/raiden that referenced this issue Jan 18, 2019
@LefterisJP @hackaugusto
Add a v prefix to the api version
eac6b61 
Fix raiden-network#3157
hackaugusto pushed a commit to hackaugusto/raiden that referenced this issue Jan 25, 2019
@LefterisJP @hackaugusto
Add a v prefix to the api version
7434735 
Fix raiden-network#3157
hackaugusto pushed a commit to hackaugusto/raiden that referenced this issue Jan 25, 2019
@LefterisJP @hackaugusto
Add a v prefix to the api version
9f18082 
Fix raiden-network#3157
hackaugusto pushed a commit to hackaugusto/raiden that referenced this issue Jan 25, 2019
@LefterisJP @hackaugusto
Add a v prefix to the api version
375fdaa 
Fix raiden-network#3157
hackaugusto pushed a commit to hackaugusto/raiden that referenced this issue Jan 25, 2019
@LefterisJP @hackaugusto
Add a v prefix to the api version
a701c0c 
Fix raiden-network#3157
hackaugusto pushed a commit to hackaugusto/raiden that referenced this issue Jan 25, 2019
@LefterisJP @hackaugusto
Add a v prefix to the api version
4cf07b5 
Fix raiden-network#3157
hackaugusto pushed a commit to hackaugusto/raiden that referenced this issue Jan 25, 2019
@LefterisJP @hackaugusto
Add a v prefix to the api version
9221048 
Fix raiden-network#3157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LefterisJP LefterisJP

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LefterisJP