Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using web3.txpool.inspect for geth #4976

Closed
LefterisJP opened this issue Sep 25, 2019 · 0 comments · Fixed by #4978
Closed

Stop using web3.txpool.inspect for geth #4976

LefterisJP opened this issue Sep 25, 2019 · 0 comments · Fixed by #4978
Assignees
@LefterisJP
Projects
Raiden Client
Milestone
Alderaan

Comments

@LefterisJP
Copy link
Contributor

LefterisJP commented Sep 25, 2019 •
edited

Problem Definition

We have had some special case handling of nonce both for parity and for geth.

The reason for this can be seen in this issue.

Us using those two functions unfortunately makes usage of Infura unsafe since they do not expose these two functions.

After talks with them it may be possible to expose the parity_nextNonce function but not the web3.txpool.inspect one for technical reasons.

The good point is that it seems that since we did this geth has fixed their issue and eth_getTransactionCount() works as intended including the pending nonces: ethereum/go-ethereum#2880

Task

  • Remove the special handling for nonces in geth since they have fixed the issue from their side and eth_getTransactionCount() works as intended.
  • Once infura exposes the parity function then we can also remove the infura warning
@LefterisJP LefterisJP added this to the Alderaan milestone Sep 25, 2019
@LefterisJP LefterisJP self-assigned this Sep 25, 2019
@LefterisJP LefterisJP added this to Backlog in Raiden Client via automation Sep 25, 2019
@rakanalh rakanalh moved this from Backlog to Planned in Raiden Client Sep 25, 2019
@rakanalh rakanalh moved this from Planned to In progress in Raiden Client Sep 25, 2019
LefterisJP added a commit to LefterisJP/raiden that referenced this issue Sep 25, 2019
@LefterisJP
Stop using txpool inspect for geth
83f3d8f 
Fix raiden-network#4976

Instead use web3.eth.getTransactionCount(address, "pending") which now
works as intended since
ethereum/go-ethereum#2880 has been fixed
@LefterisJP LefterisJP mentioned this issue Sep 25, 2019
Merged
13 tasks
Raiden Client automation moved this from In progress to Done Sep 25, 2019
rakanalh pushed a commit that referenced this issue Sep 25, 2019
@LefterisJP @rakanalh
Stop using txpool inspect for geth
8db4ad2 
Fix #4976

Instead use web3.eth.getTransactionCount(address, "pending") which now
works as intended since
ethereum/go-ethereum#2880 has been fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LefterisJP LefterisJP

Labels
None yet
Projects
No open projects
Raiden Client
  
Done
Milestone
Alderaan
Development

Successfully merging a pull request may close this issue.

Geth stop using txpool api LefterisJP/raiden
1 participant
@LefterisJP