Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geth stop using txpool api #4978

Merged
merged 3 commits into from Sep 25, 2019

Conversation

LefterisJP
Copy link
Contributor

Fixes: #4976

PR review check list

Quality check list that cannot be automatically verified.

  • Safety
  • Code quality
    • Error conditions are handled
    • Exceptions are propagated to the correct parent greenlet
    • Exceptions are correctly classified as recoverable or unrecoverable
  • Compatibility
    • State changes are forward compatible
    • Transport messages are backwards and forward compatible
  • Commits
    • Have good messages
    • Squashed unecessary commits
  • If it's a bug fix:
    • Regression test for the bug
      • Properly covers the bug
      • If an integration test is used, it could not be written as a unit test
  • Documentation
    • A new CLI flag was introduced, is there documentation that explains usage?
  • Specs
    • If this is a protocol change, are the specs updated accordingly? If so, please link PR from the specs repo.
  • Is it a user facing feature/bug fix?
    • Changelog entry has been added

Fix raiden-network#4976

Instead use web3.eth.getTransactionCount(address, "pending") which now
works as intended since
ethereum/go-ethereum#2880 has been fixed
@auto-assign auto-assign bot requested a review from karlb September 25, 2019 10:13
@LefterisJP
Copy link
Contributor Author

This is succesfully tested by the following test:

def test_geth_discover_next_available_nonce(

@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #4978 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4978      +/-   ##
===========================================
+ Coverage    80.66%   80.69%   +0.02%     
===========================================
  Files          120      120              
  Lines        14606    14594      -12     
  Branches      2264     2260       -4     
===========================================
- Hits         11782    11776       -6     
  Misses        2156     2156              
+ Partials       668      662       -6
Impacted Files Coverage Δ
raiden/ui/checks.py 54.76% <ø> (ø) ⬆️
raiden/network/rpc/client.py 76.53% <100%> (+0.38%) ⬆️
raiden/network/transport/matrix/client.py 68.5% <0%> (-1.3%) ⬇️
raiden/network/proxies/token_network.py 50.42% <0%> (-0.74%) ⬇️
raiden/api/python.py 68.33% <0%> (-0.53%) ⬇️
raiden/transfer/channel.py 89.21% <0%> (-0.23%) ⬇️
raiden/network/transport/matrix/transport.py 80.94% <0%> (+0.91%) ⬆️
raiden/waiting.py 85.71% <0%> (+4%) ⬆️
raiden/storage/serialization/types.py 68.65% <0%> (+4.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 114f5a4...f32e282. Read the comment docs.

@rakanalh rakanalh requested review from rakanalh and removed request for karlb September 25, 2019 12:04
Copy link
Contributor

@rakanalh rakanalh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rakanalh rakanalh merged commit fc4be44 into raiden-network:develop Sep 25, 2019
@LefterisJP LefterisJP deleted the geth_stop_using_txpool branch September 25, 2019 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop using web3.txpool.inspect for geth
2 participants