Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify jsonrpc constructor #2066

Merged
merged 3 commits into from Aug 7, 2018
Merged

Simplify jsonrpc constructor #2066

merged 3 commits into from Aug 7, 2018

Commits on Aug 6, 2018

  1. Simplified JSONRPCClient constructor 

    The arguments host and port were ignored the argument web3 was given,
this could lead to inconsistencies among the web3 instance and the
JSONRPCClient's attributes host/port. This change removes the extranous
arguments and requires the web3 instance.

[ci integration]
    @hackaugusto
    hackaugusto committed Aug 6, 2018
    Copy the full SHA
    54b5be5 View commit details
    Browse the repository at this point in the history

  2. Moved sys.exit out of the JSONRPCClient constructor 

    [ci integration]
    @hackaugusto
    hackaugusto committed Aug 6, 2018
    Copy the full SHA
    3e3d060 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2018

  1. pr review

    @hackaugusto
    hackaugusto committed Aug 7, 2018
    Copy the full SHA
    bf32483 View commit details
    Browse the repository at this point in the history