Fix polling mechanism issues #2286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrevmatos
approved these changes
Aug 27, 2018
|
|
||
| it('should not throw if a channel is removed from the list', fakeAsync(() => { | ||
| raidenServiceSpy.and.returnValues(from([[channel1, channel2], [channel1]])); | ||
| const subcription = pollingService.channels().subscribe(); |
|
|
||
| it('should not show a notification for the same identifier on different network', fakeAsync(() => { | ||
| raidenServiceSpy.and.returnValues(from([[channel1, channel1Network2], [channel1Network2]])); | ||
| const subcription = pollingService.channels().subscribe(); |
This would happen because the the polling mechanism only checked a channels identifier to determine unique channels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes channel identification mechanism to include
token_addressalong withchannel_identifierAdd check for newChannel being null when checking for balance changes.
Closes #2282
Closes #2284