Raiden --showconfig flag #2737
Raiden --showconfig flag #2737
Conversation
There was a problem hiding this comment.
Our configuration is in toml, I don't see the point of printing it out in a different format. Additionally, I don't trust yaml since it has some really weird extensions that make it a security vulnerability, from the docs:
Warning: It is not safe to call yaml.load with any data received from an untrusted source! yaml.load is as powerful as pickle.load and so may call any Python function. Check the yaml.safe_load function though.
|
@hackaugusto the idea was that yaml displays better than JSON... and Toml looks more like |
|
While I agree that there is not really a need for using yaml, the safety argument doesn't really come into play here since we're only writing yaml. (And generally |
|
Alright, i'll update it to use Toml instead. |
|
@rakanalh needs rebase |
|
Rebased + Changed config dump format to Toml |
[no ci integration]
constraints.txt
Outdated
| @@ -65,6 +65,7 @@ pystun-patched-for-raiden==0.1.0 | |||
| pytest==3.8.0 | |||
| pytoml==0.1.19 | |||
| pytz==2018.5 | |||
| pyyaml==3.13 | |||
There was a problem hiding this comment.
we dont need this dependency anymore
requirements.txt
Outdated
| @@ -22,6 +22,7 @@ py-solc | |||
| pystun-patched-for-raiden | |||
| pytest | |||
| pytoml | |||
| pyyaml | |||
There was a problem hiding this comment.
we dont need this dependency anymore
raiden/ui/runners.py
Outdated
| print('Configuration Dump:') | ||
| dump_config(config) | ||
| dump_cmd_options(self._options) | ||
| dump_module('cettings', settings) |
|
|
||
| def dump_cmd_options(options): | ||
| print(toml.dumps({ | ||
| 'options': _clean_non_serializables(options), |
There was a problem hiding this comment.
in the future we should definitely remove the non serialize objects from the options dictionary
There was a problem hiding this comment.
I agree... the merged splitting of CLI opened up the door way for a little bit of refactoring as i wouldn't call what i did there as a refactor of the code but rather more organization. But we should definitely look into the way we pass data around between CLI components.
[ci integration-cli]
raiden/ui/config.py
Outdated
| import inspect | ||
| from enum import Enum | ||
|
|
||
| import toml |
There was a problem hiding this comment.
we don't have toml in requirements :( you should use pytoml
[ci integration-cli]
Resolves #2708
Depends on #2715