Change HABTM to has_many :through #404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HABTM is basicaly bridge to has_many :through now. Quoting from ActiveRecord changelog: has_and_belongs_to_many is now transparently implemented in terms of has_many :through. Behavior should remain the same, if not, it is a bug.
|
Closing, Rails issue rails/rails#12582 |
|
This should be now fixed: rails/rails@da3891c |
|
@strzalek 👍 I'm going to move out master from the allow_failure on Gemfile.edge |
|
Maybe wait a bit with this as I'm not sure if this issue is actually fixed. I've run tests on edge locally and they're still failing. I'll check this later today. |
|
@strzalek tests are passing now on AMS :) |
|
Awesome then! 🤘 On Wed, Dec 18, 2013 at 11:48 PM, Santiago Pastorino <
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HABTM is basically bridge to has_many :through now.
Quoting from ActiveRecord changelog (https://github.com/rails/rails/blob/master/activerecord/CHANGELOG.md):
has_and_belongs_to_many is now transparently implemented in terms of has_many :through.
Behavior should remain the same, if not, it is a bug.