Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change HABTM to has_many :through #404

Closed
wants to merge 1 commit into from

Conversation

lukaszx0
Copy link
Member

HABTM is basically bridge to has_many :through now.

Quoting from ActiveRecord changelog (https://github.com/rails/rails/blob/master/activerecord/CHANGELOG.md):

has_and_belongs_to_many is now transparently implemented in terms of has_many :through.
Behavior should remain the same, if not, it is a bug.

HABTM is basicaly bridge to has_many :through now.

Quoting from ActiveRecord changelog:

  has_and_belongs_to_many is now transparently implemented in terms of has_many :through.
  Behavior should remain the same, if not, it is a bug.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) when pulling 613792f on strzalek:fix-edge-tests into 3abbbc6 on rails-api:rewrite.

@spastorino
Copy link
Contributor

Closing, Rails issue rails/rails#12582

@spastorino spastorino closed this Oct 18, 2013
@lukaszx0
Copy link
Member Author

This should be now fixed: rails/rails@da3891c

@spastorino
Copy link
Contributor

@strzalek 👍 I'm going to move out master from the allow_failure on Gemfile.edge

@lukaszx0
Copy link
Member Author

Maybe wait a bit with this as I'm not sure if this issue is actually fixed. I've run tests on edge locally and they're still failing.

I'll check this later today.

@spastorino
Copy link
Contributor

@strzalek tests are passing now on AMS :)

@lukaszx0
Copy link
Member Author

Awesome then! 🤘

On Wed, Dec 18, 2013 at 11:48 PM, Santiago Pastorino <
notifications@github.com> wrote:

@strzalek https://github.com/strzalek with AMS tests are passing now :)


Reply to this email directly or view it on GitHubhttps://github.com//pull/404#issuecomment-30889093
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants