Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ActionController::Serialization when loading 'abstract_controller' #519

Closed
wants to merge 2 commits into from

Conversation

rafaellima
Copy link

When inheriting from ActionController::Metal instead of ActionController::Base on my controllers I'm not able to use serializers properly. There is a workaround to fix that (which is to actually include this module on my controller and override a method called url_options) but I don't think it's the better way to fix that.

I'm not sure if it's the better way to solve this, but it worked just fine for me.

@arthurnn
Copy link
Contributor

👍 on my side

@rafaellima
Copy link
Author

@spastorino any thoughts?

@spastorino
Copy link
Contributor

I'm very busy right now, ping @xymbol

@xymbol
Copy link
Contributor

xymbol commented Mar 12, 2014

@rafaellima Could you add a test under integration for this? Thanks!

@xymbol xymbol self-assigned this Mar 12, 2014
@xymbol xymbol added the waiting label Mar 12, 2014
@rafaellima
Copy link
Author

@xymbol check it out please.

@steveklabnik
Copy link
Contributor

This looks fine, but it needs a rebase.

@rafaellima
Copy link
Author

@steveklabnik rebase is done.

@steveklabnik
Copy link
Contributor

Thank you! I'm going to investigate this travis weirdness.

@steveklabnik
Copy link
Contributor

Okay! These tests are failing on Rails 4.1. I'm still interested in merging this, but the branches are changing, so please re-submit to the 0-9-stable branch. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants