Rename root file to match gem name #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that bundler automatically requires 'activemodel-serializers-xml'.
|
This is causing issues like rails/rails#24558 cc @rafaelfranca |
|
Thanks |
ulissesalmeida
added a commit
to heartcombo/devise
that referenced
this pull request
Apr 15, 2016
With this [PR](rails/activemodel-serializers-xml#8) of activemodel-serializers bundle will require it by default.
kimgb
pushed a commit
to kimgb/devise
that referenced
this pull request
Apr 21, 2016
With this [PR](rails/activemodel-serializers-xml#8) of activemodel-serializers bundle will require it by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets bundler automatically require 'activemodel-serializers-xml'.
Without renaming the root file to match the gem file name bundler does not automatically require the gem. I.e. Without this change the following require is needed in the application for it to work: