support MySQL and PostgreSQL extended DELETE syntax #228
Conversation
also do joins natively for mysql both require rails/arel#228
|
Seeing partial test coverage for the new delete case. There are more behavior changes here, though. Could you expand to full coverage? |
|
@jeremy I added additional test coverage. |
|
any update on this? do you want the commits squashed together? |
|
@ccutrer needs a rebase |
ccutrer
force-pushed
the
mysql-extended-delete
branch
from
de0204f
to
72745c1
Compare
|
@tamird rebased and changed code to match newer code style (using collector in visitors, and compile method in test - which passes a collector) |
|
probably needs a review from @tenderlove |
|
|
||
| def initialize relation = nil, wheres = [] | ||
| super |
There was a problem hiding this comment.
Did you mean to remove the call to super?
There was a problem hiding this comment.
I did not. probably got confused in the conflicts when I rebased
ccutrer
force-pushed
the
mysql-extended-delete
branch
from
72745c1
to
c663fa2
Compare
|
@ccutrer can you squash the relevant parts of the last commit into the other two? the changes look good to me, @rafaelfranca can you please triage? |
this also fixes the general case by using a subselect rather than a direct limit (which is not standard SQL)
ccutrer
force-pushed
the
mysql-extended-delete
branch
from
c663fa2
to
18be55a
Compare
|
@tamird - squashed down to two commits. |
|
would love to see this get in 👍 cc @tenderlove |
|
LGTM, but @sgrif can you review? |
|
Per #523, Arel development is moving to rails/rails. If this PR is still relevant, please consider reopening it over there. |
note that this also adds support for limit on all adapters by doing a subquery (just like update)