Make an ast for compile_update as needed #241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a test case for this? |
|
@lloeki needs a test. otherwise, will close soon |
|
Got it. Life's pretty tough right now but I will try to get something soon. |
|
@lloeki Here's a test for reference for updating https://gist.github.com/vipulnsward/c6a24b0221264b5ab3b9 |
|
@vipulnsward Thanks for the pointer, I'll commit on getting that done by the end of the week. |
`my_table.compile_update(whatever)` alone crashes because the ast is nil, whereas both `my_table.where(something).compile_update(whatever)` and `my_table.select_manager.compile_update(whatever)` have their way. This lets the problematic case behave like the latter. This takes care of `compile_insert` and `compile_delete` as well.
lloeki
force-pushed
the
compile_update_without_ast
branch
from
b197647
to
79bf3fb
Compare
|
Here are the tests, also for insert (which did not require anything to pass) and delete (which required some context to be added) |
|
Per #523, Arel development is moving to rails/rails. If this PR is still relevant, please consider reopening it over there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my_table.compile_update(whatever)alone crashes because the ast is nil, whereas bothmy_table.where(something).compile_update(whatever)andmy_table.select_manager.compile_update(whatever)have their way.This lets the problematic case behave like the latter.
This might apply to
compile_insertandcompile_deleteas well.