Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for spec removal #55

Closed
ereslibre opened this issue Apr 15, 2012 · 1 comment
Closed

Request for spec removal #55

ereslibre opened this issue Apr 15, 2012 · 1 comment

Comments

@ereslibre
Copy link

Given there are no real tests for this gem I suggest to remove them. It's not adapted to RSpec2 and outdated since Rails::Generators.configure! now takes one argument.

Also, I think it makes sense since this gem only provides jquery through the asset pipeline and has not logic to test.

The reason is because if a project dynamically runs all tests over all engines that are loaded, it has to skip jquery-rails explicitly to make tests pass.

@jeremy
Copy link
Member

jeremy commented Apr 16, 2012

Closed by #56

@jeremy jeremy closed this as completed Apr 16, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants