Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS override question #61

Closed
rctneil opened this issue Jan 8, 2022 · 0 comments
Closed

CSS override question #61

rctneil opened this issue Jan 8, 2022 · 0 comments

Comments

@rctneil
Copy link

rctneil commented Jan 8, 2022

Hi,

In relation to the question and answer in the readme:

Why does esbuild overwrite my application.css?
If you import CSS in your application.js while using esbuild, you'll be creating both an app/assets/builds/application.js and app/assets/builds/application.css file when bundling. The latter can conflict with the app/assets/builds/application.css produced by cssbundling-rails. The solution is to either change the output file for esbuild (and the references for that) or for cssbundling. Both are specified in package.json.

I changed the line in my package.json to "build:css": "sass ./app/assets/stylesheets/application.sass.scss ./app/assets/builds/application-styles.css --no-source-map --load-path=node_modules" but I expected to have to update my stylesheet_link_tag line in my layout and I also expected a file in app/assets/builds called application-style.css, but I don;t get that file and I didn't have to update my view.

Why does this work? Please could someone explain a little further to help me understand.

Thanks

@rails rails locked and limited conversation to collaborators Jan 13, 2022
@dhh dhh converted this issue into discussion #64 Jan 13, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant