Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate new elements for unique lists #58

Merged
merged 2 commits into from
Dec 3, 2021

Conversation

excid3
Copy link
Contributor

@excid3 excid3 commented Dec 3, 2021

Unique lists validates the new elements were not an empty list, but does not check for duplicate items in the array being passed in.

This makes removes any duplicates before passing them to Redis.

@kaspth
Copy link
Contributor

kaspth commented Dec 3, 2021

Discussed with @excid3 to remove the rare and untested flatten handling and let callers handle that.

@kaspth kaspth merged commit 8b77172 into rails:main Dec 3, 2021
@excid3 excid3 deleted the deduplicate-new-elements branch December 3, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants