Skip to content

Commit

Permalink
Allow spaces in postgres table names
Browse files Browse the repository at this point in the history
Fixes issue where "user post" is misinterpreted as "\"user\".\"post\""
when quoting table names with the postgres adapter.
  • Loading branch information
gmcgibbon committed Nov 28, 2018
1 parent 9c6e362 commit 03fadeb
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 1 deletion.
6 changes: 6 additions & 0 deletions activerecord/CHANGELOG.md
@@ -1,3 +1,9 @@
* Allow spaces in postgres table names.

Fixes issue where "user post" is misinterpreted as "\"user\".\"post\"" when quoting table names with the postgres adapter.

*Gannon McGibbon*

* Cached columns_hash fields should be excluded from ResultSet#column_types

PR #34528 addresses the inconsistent behaviour when attribute is defined for an ignored column. The following test
Expand Down
Expand Up @@ -68,7 +68,7 @@ module Utils # :nodoc:
# * <tt>"schema_name".table_name</tt>
# * <tt>"schema.name"."table name"</tt>
def extract_schema_qualified_name(string)
schema, table = string.scan(/[^".\s]+|"[^"]*"/)
schema, table = string.scan(/[^".]+|"[^"]*"/)
if table.nil?
table = schema
schema = nil
Expand Down
5 changes: 5 additions & 0 deletions activerecord/test/cases/adapters/postgresql/quoting_test.rb
Expand Up @@ -39,6 +39,11 @@ def test_quote_bit_string
type = OID::Bit.new
assert_nil @conn.quote(type.serialize(value))
end

def test_quote_table_name_with_spaces
value = "user posts"
assert_equal "\"user posts\"", @conn.quote_table_name(value)
end
end
end
end
Expand Down

0 comments on commit 03fadeb

Please sign in to comment.