Skip to content

Commit

Permalink
assert on empty array is always true. fixing test.
Browse files Browse the repository at this point in the history
  • Loading branch information
Neeraj Singh authored and tenderlove committed Sep 30, 2010
1 parent 6a55ca3 commit 0495736
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion activeresource/test/cases/format_test.rb
Expand Up @@ -33,7 +33,7 @@ def test_formats_on_collection
ActiveResource::HttpMock.respond_to.get "/people.#{format}", {'Accept' => ActiveResource::Formats[format].mime_type}, ActiveResource::Formats[format].encode(@programmers)

This comment has been minimized.

Copy link
@j7d6

j7d6 Oct 23, 2012

q

This comment has been minimized.

Copy link
@kheradmand

kheradmand Jul 27, 2013

test

remote_programmers = Person.find(:all)

This comment has been minimized.

Copy link
@poison

poison Nov 15, 2011

dangerous

assert_equal 2, remote_programmers.size

This comment has been minimized.

Copy link
@anandagar

anandagar Dec 24, 2011

test

This comment has been minimized.

Copy link
@gutman23

gutman23 Aug 1, 2013

test

assert remote_programmers.select { |p| p.name == 'David' }

This comment has been minimized.

Copy link
@crazybob

crazybob Feb 8, 2011

Hmmmm...

This comment has been minimized.

Copy link
@sasha1sum

sasha1sum Nov 11, 2011

asdf

This comment has been minimized.

Copy link
@Muralidharan

Muralidharan Dec 15, 2011

Testing

This comment has been minimized.

Copy link
@nonull

nonull Mar 19, 2012

Wow

This comment has been minimized.

Copy link
@j7d6

j7d6 Oct 23, 2012

woop

This comment has been minimized.

Copy link
@nycgavin

nycgavin Feb 26, 2013

yo

assert remote_programmers.map { |p| p.name }.include? 'David'

This comment has been minimized.

Copy link
@2shortplanks

2shortplanks Jan 11, 2011

Can we change to a more descriptive variable name too?

This comment has been minimized.

Copy link
@la3lma

la3lma Sep 6, 2011

Blah, Humbug

This comment has been minimized.

Copy link
@kobkrit

kobkrit Jan 9, 2012

Yahoo!

This comment has been minimized.

Copy link
@lisandroTSilva

lisandroTSilva Aug 23, 2013

teste

end
end

This comment has been minimized.

Copy link
@dalbrekt

dalbrekt Sep 19, 2013

no way

This comment has been minimized.

Copy link
@dalbrekt

dalbrekt Sep 19, 2013

way!

end

This comment has been minimized.

Copy link
@excursively

excursively Jul 11, 2012

kri kri, last line.

This comment has been minimized.

Copy link
@hbjerry

hbjerry Feb 18, 2013

last line

This comment has been minimized.

Copy link
@NightmaresWithin

NightmaresWithin Jun 28, 2013

This is definitely the end! AAAAhhhhh

Expand Down

11 comments on commit 0495736

@miloops
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not using any, detect or find instead of both map and include?

@tenderlove
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miloops good question. I changed it here: ef8ce78

@neerajsingh0101
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what I was thinking . Thanks for the correction.

@sikachu
Copy link
Member

@sikachu sikachu commented on 0495736 Jun 9, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's going on with the comment thread here?

@sarahhodne
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sikachu This page is featured on https://github.com/features/projects/codereview, that may be why.

@barnabytprowe
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing

@jameshsieh
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我測試,很好!

@mhuggins
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I missing some joke? What's with all the 'test' comments and the like?

@steveklabnik
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JinsooHan
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5686 This is issue number link.

@nimeia
Copy link

@nimeia nimeia commented on 0495736 Oct 8, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicai

Please sign in to comment.