Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

assert on empty array is always true. fixing test.

  • Loading branch information...
commit 0495736339df48a625fd58f4304b7b497b02d859 1 parent 6a55ca3
Neeraj Singh neerajdotname authored tenderlove committed
Showing with 1 addition and 1 deletion.
  1. +1 −1  activeresource/test/cases/format_test.rb
2  activeresource/test/cases/format_test.rb
View
@@ -33,7 +33,7 @@ def test_formats_on_collection
ActiveResource::HttpMock.respond_to.get "/people.#{format}", {'Accept' => ActiveResource::Formats[format].mime_type}, ActiveResource::Formats[format].encode(@programmers)
Jan Diekmann
j7d6 added a note

q

test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
remote_programmers = Person.find(:all)
Nicolas
poison added a note

dangerous

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
assert_equal 2, remote_programmers.size

test

gutman23
gutman23 added a note

test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
- assert remote_programmers.select { |p| p.name == 'David' }
crazybob
crazybob added a note

Hmmmm...

asdf

Testing

nonull
nonull added a note

Wow

Jan Diekmann
j7d6 added a note

woop

yo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+ assert remote_programmers.map { |p| p.name }.include? 'David'

Can we change to a more descriptive variable name too?

Bjørn Remseth
la3lma added a note

Blah, Humbug

Kobkrit Viriyayudhakorn
kobkrit added a note

Yahoo!

teste

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
end
end

no way

way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
end
Sataporn Saijai
xphp added a note

kri kri, last line.

hbjerry
hbjerry added a note

last line

This is definitely the end! AAAAhhhhh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

11 comments on commit 0495736

Emilio Tagua

Why not using any, detect or find instead of both map and include?

Aaron Patterson
Owner

@miloops good question. I changed it here: ef8ce78

Neeraj Singh
Collaborator

Not sure what I was thinking . Thanks for the correction.

Mark Fowler

Can we change to a more descriptive variable name too?

Prem Sichanugrist
Collaborator

What's going on with the comment thread here?

Henrik Hodne

@sikachu This page is featured on https://github.com/features/projects/codereview, that may be why.

Prem Sichanugrist

Houston - I can hear you loud and clear.

Barnaby Rowe

Testing

James

我測試,很好!

Matt Huggins

Am I missing some joke? What's with all the 'test' comments and the like?

JinsooHan

#5686 This is issue number link.

Nightmares Within

This is definitely the end! AAAAhhhhh

YD.D.小钱钱

nicai

Please sign in to comment.
Something went wrong with that request. Please try again.