Permalink
Browse files

assert on empty array is always true. fixing test.

  • Loading branch information...
Neeraj Singh authored and tenderlove committed Sep 30, 2010
1 parent 6a55ca3 commit 0495736339df48a625fd58f4304b7b497b02d859
Showing with 1 addition and 1 deletion.
  1. +1 −1 activeresource/test/cases/format_test.rb
@@ -33,7 +33,7 @@ def test_formats_on_collection
ActiveResource::HttpMock.respond_to.get "/people.#{format}", {'Accept' => ActiveResource::Formats[format].mime_type}, ActiveResource::Formats[format].encode(@programmers)

This comment has been minimized.

Show comment
Hide comment

This comment has been minimized.

Show comment
Hide comment
remote_programmers = Person.find(:all)

This comment has been minimized.

Show comment
Hide comment
@poison

poison Nov 15, 2011

dangerous

assert_equal 2, remote_programmers.size

This comment has been minimized.

Show comment
Hide comment

This comment has been minimized.

Show comment
Hide comment
- assert remote_programmers.select { |p| p.name == 'David' }

This comment has been minimized.

Show comment
Hide comment

This comment has been minimized.

Show comment
Hide comment

This comment has been minimized.

Show comment
Hide comment

This comment has been minimized.

Show comment
Hide comment

This comment has been minimized.

Show comment
Hide comment

This comment has been minimized.

Show comment
Hide comment
+ assert remote_programmers.map { |p| p.name }.include? 'David'

This comment has been minimized.

Show comment
Hide comment
@2shortplanks

2shortplanks Jan 11, 2011

Can we change to a more descriptive variable name too?

@2shortplanks

2shortplanks Jan 11, 2011

Can we change to a more descriptive variable name too?

This comment has been minimized.

Show comment
Hide comment
@la3lma

la3lma Sep 6, 2011

Blah, Humbug

@la3lma

la3lma Sep 6, 2011

Blah, Humbug

This comment has been minimized.

Show comment
Hide comment

This comment has been minimized.

Show comment
Hide comment
end
end

This comment has been minimized.

Show comment
Hide comment

This comment has been minimized.

Show comment
Hide comment
end

This comment has been minimized.

Show comment
Hide comment
@excursively

excursively Jul 11, 2012

kri kri, last line.

@excursively

excursively Jul 11, 2012

kri kri, last line.

This comment has been minimized.

Show comment
Hide comment
@hbjerry

hbjerry Feb 18, 2013

last line

This comment has been minimized.

Show comment
Hide comment
@NightmaresWithin

NightmaresWithin Jun 28, 2013

This is definitely the end! AAAAhhhhh

@NightmaresWithin

NightmaresWithin Jun 28, 2013

This is definitely the end! AAAAhhhhh

11 comments on commit 0495736

@miloops

This comment has been minimized.

Show comment
Hide comment
@miloops

miloops Sep 30, 2010

Contributor

Why not using any, detect or find instead of both map and include?

Contributor

miloops replied Sep 30, 2010

Why not using any, detect or find instead of both map and include?

@tenderlove

This comment has been minimized.

Show comment
Hide comment
@tenderlove

tenderlove Sep 30, 2010

Member

@miloops good question. I changed it here: ef8ce78

Member

tenderlove replied Sep 30, 2010

@miloops good question. I changed it here: ef8ce78

@neerajdotname

This comment has been minimized.

Show comment
Hide comment
@neerajdotname

neerajdotname Sep 30, 2010

Member

Not sure what I was thinking . Thanks for the correction.

Member

neerajdotname replied Sep 30, 2010

Not sure what I was thinking . Thanks for the correction.

@sikachu

This comment has been minimized.

Show comment
Hide comment
@sikachu

sikachu Jun 9, 2011

Member

What's going on with the comment thread here?

Member

sikachu replied Jun 9, 2011

What's going on with the comment thread here?

@sarahhodne

This comment has been minimized.

Show comment
Hide comment
@sarahhodne

sarahhodne Nov 6, 2011

Contributor

@sikachu This page is featured on https://github.com/features/projects/codereview, that may be why.

Contributor

sarahhodne replied Nov 6, 2011

@sikachu This page is featured on https://github.com/features/projects/codereview, that may be why.

@barnabytprowe

This comment has been minimized.

Show comment
Hide comment

Testing

@jameshsieh

This comment has been minimized.

Show comment
Hide comment
@jameshsieh

jameshsieh Oct 11, 2012

我測試,很好!

我測試,很好!

@mhuggins

This comment has been minimized.

Show comment
Hide comment
@mhuggins

mhuggins Oct 23, 2012

Am I missing some joke? What's with all the 'test' comments and the like?

Am I missing some joke? What's with all the 'test' comments and the like?

@steveklabnik

This comment has been minimized.

Show comment
Hide comment
@JinsooHan

This comment has been minimized.

Show comment
Hide comment
@JinsooHan

JinsooHan Mar 14, 2013

#5686 This is issue number link.

#5686 This is issue number link.

@nimeia

This comment has been minimized.

Show comment
Hide comment

nicai

Please sign in to comment.