Browse files

assert on empty array is always true. fixing test.

  • Loading branch information...
1 parent 6a55ca3 commit 0495736339df48a625fd58f4304b7b497b02d859 Neeraj Singh committed with tenderlove Sep 30, 2010
Showing with 1 addition and 1 deletion.
  1. +1 −1 activeresource/test/cases/format_test.rb
View
2 activeresource/test/cases/format_test.rb
@@ -33,7 +33,7 @@ def test_formats_on_collection
ActiveResource::HttpMock.respond_to.get "/people.#{format}", {'Accept' => ActiveResource::Formats[format].mime_type}, ActiveResource::Formats[format].encode(@programmers)
@j7d6
j7d6 added a note Oct 23, 2012

q

test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
remote_programmers = Person.find(:all)
@poison
poison added a note Nov 15, 2011

dangerous

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
assert_equal 2, remote_programmers.size

test

@gutman23
gutman23 added a note Aug 1, 2013

test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
- assert remote_programmers.select { |p| p.name == 'David' }
@crazybob
crazybob added a note Feb 8, 2011

Hmmmm...

asdf

Testing

@nonull
nonull added a note Mar 19, 2012

Wow

@j7d6
j7d6 added a note Oct 23, 2012

woop

yo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+ assert remote_programmers.map { |p| p.name }.include? 'David'

Can we change to a more descriptive variable name too?

@la3lma
la3lma added a note Sep 6, 2011

Blah, Humbug

@kobkrit
kobkrit added a note Jan 9, 2012

Yahoo!

teste

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
end
end

no way

way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
end

kri kri, last line.

@hbjerry
hbjerry added a note Feb 18, 2013

last line

This is definitely the end! AAAAhhhhh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

11 comments on commit 0495736

@miloops

Why not using any, detect or find instead of both map and include?

@tenderlove
Ruby on Rails member

@miloops good question. I changed it here: ef8ce78

@neerajdotname
Ruby on Rails member

Not sure what I was thinking . Thanks for the correction.

@sikachu
Ruby on Rails member

What's going on with the comment thread here?

@henrikhodne

@sikachu This page is featured on https://github.com/features/projects/codereview, that may be why.

@barnabytprowe

Testing

@jameshsieh

我測試,很好!

@mhuggins

Am I missing some joke? What's with all the 'test' comments and the like?

@JinsooHan

#5686 This is issue number link.

@nimeia

nicai

Please sign in to comment.