fix difference between behaviour of blank and empty

Signed-off-by: José Valim <jose.valim@gmail.com>
rails · Jan 5, 2011 · 05da752 · 05da752
1 parent b7bb795
commit 05da752
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/activemodel/lib/active_model/errors.rb b/activemodel/lib/active_model/errors.rb
@@ -149,7 +149,7 @@ def count
     def empty?
       all? { |k, v| v && v.empty? }
     end
-
+    alias_method :blank?, :empty?
     # Returns an xml formatted representation of the Errors hash.
     #
     #   p.errors.add(:name, "can't be blank")

diff --git a/activemodel/test/cases/errors_test.rb b/activemodel/test/cases/errors_test.rb
@@ -25,7 +25,13 @@ def self.human_attribute_name(attr, options = {})
     def self.lookup_ancestors
       [self]
     end
+  end
 
+  test "should return true if no errors" do
+    person = Person.new
+    person.errors[:foo]
+    assert person.errors.empty?
+    assert person.errors.blank?
   end
 
   test "method validate! should work" do